Skip to content

Conversation

@CodyReichert
Copy link
Member

Use an <img/> tag for the photo in [sr_listings] and [sr_listings_slider] instead of a <div>.

Also add an alt and title attribute to these images, to improve SEO.

@CodyReichert CodyReichert added enhancement This is an enhancement or new feature merge This PR can be merged by a maintainer labels Jan 18, 2021
@CodyReichert CodyReichert self-assigned this Jan 18, 2021
@CodyReichert CodyReichert removed the merge This PR can be merged by a maintainer label Jan 18, 2021
@CodyReichert
Copy link
Member Author

The only issue with this is that many people are probably targeting the old div elements in their custom CSS (ie, for a grid layout, someone may be targeting these elements).

Either we need to push a major version or have some backwards compatibility.

II'll just hang on to this one for now and likely merge it with other structural markup changes in a new major version.

@CodyReichert CodyReichert added the template This issue or PR affects user-facing markup label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This is an enhancement or new feature template This issue or PR affects user-facing markup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants