Skip to content

Use better HTML for images in sr_listings/sr_listings_slider #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodyReichert wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use better HTML for images in sr_listings/sr_listings_slider #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/assets/css/simply-rets-client.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,11 @@ of the image, use this class.
```

*/
.sr-photo {
position: relative;
img.sr-photo {
display: inline-block;
height: 155px;
width: 30%;
overflow: hidden;
background-size: contain;
background-position: center center;
background-repeat: no-repeat;
}


Expand Down Expand Up @@ -918,11 +914,9 @@ elsewhere, this should be a breeze.
text-align: center;
}

.sr-listing-slider-item-img {
height: 170px;
background-size: contain;
background-position: center;
background-repeat: no-repeat;
img.sr-listing-slider-item-img {
height: 150px;
object-fit: cover;
}

.sr-listing-slider-item-address {
Expand Down
15 changes: 12 additions & 3 deletions src/simply-rets-api-helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1538,8 +1538,12 @@ public static function srResidentialResultsGenerator( $response, $settings ) {
<hr>
<div class="sr-listing">
<a href="$link">
<div class="sr-photo" style="background-image:url('$main_photo');">
</div>
<img
src="$main_photo"
alt="$full_address - $listing_USD"
title="$full_address - $listing_USD"
class="sr-photo"
/>
</a>
<div class="sr-listing-data-wrapper">
<div class="sr-primary-data">
Expand Down Expand Up @@ -1849,7 +1853,12 @@ public static function srListingSliderGenerator( $response, $settings ) {
$inner .= <<<HTML
<div class="sr-listing-slider-item">
<a href="$link">
<div class="sr-listing-slider-item-img" style="background-image: url('$photo')"></div>
<img
src="$photo"
alt="$address - $priceUSD"
title="$address - $priceUSD"
class="sr-listing-slider-item-img"
/>
</a>
<a href="$link">
<h4 class="sr-listing-slider-item-address">$address <small>$priceUSD</small></h4>
Expand Down