fix: Allow empty values in DurationController to disable event notifications#2154
Open
Si6gma wants to merge 1 commit intoSkyblockerMod:masterfrom
Open
fix: Allow empty values in DurationController to disable event notifications#2154Si6gma wants to merge 1 commit intoSkyblockerMod:masterfrom
Si6gma wants to merge 1 commit intoSkyblockerMod:masterfrom
Conversation
…cations - Modify toString() to return empty string for duration <= 0 - Modify isValid() to accept blank strings as valid input - This allows users to clear text boxes to disable notifications as documented in the tooltip Fixes issue where emptying the notification time fields would fill them with 'Now' instead of disabling notifications
Si6gma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2148