Skip to content

fix: Allow empty values in DurationController to disable event notifications #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Si6gma wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Allow empty values in DurationController to disable event notifications #2154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/de/hysky/skyblocker/utils/config/DurationController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public DurationController() {
}

private static String toString(int duration) {
if (duration <= 0) return "";
return SkyblockTime.formatTime(duration).getString();
}

Expand All @@ -49,6 +50,9 @@ private static int fromString(String value) {
}

private static boolean isValid(String s) {
// Allow empty string to disable notifications
if (s.isBlank()) return true;

Matcher hoursMatcher = hoursPattern.matcher(s);
Matcher minutesMatcher = minutesPattern.matcher(s);
Matcher secondsMatcher = secondsPattern.matcher(s);
Expand Down