Apply maxInteractDistance to nearby entity scans (#36)#39
Open
YgorLeal wants to merge 1 commit intoSleepless-Development:mainfrom
Open
Apply maxInteractDistance to nearby entity scans (#36)#39YgorLeal wants to merge 1 commit intoSleepless-Development:mainfrom
YgorLeal wants to merge 1 commit intoSleepless-Development:mainfrom
Conversation
Closes Sleepless-Development#36. Replaces hardcoded 10.0 radius in getNearbyObjects/Vehicles/ Players/Peds with config.maxInteractDistance, and adds optional per-pool overrides (nearbyObjectsDistance, nearbyVehiclesDistance, nearbyPlayersDistance, nearbyPedsDistance) for decoupling scan radius from render distance.
YgorLeal
force-pushed
the
fix/nearby-entities-distance
branch
from
a18c663 to
83c3ca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
10.0radius ingetNearbyObjects/Vehicles/Players/Pedswithconfig.maxInteractDistance, so the existing distance config actually applies to entity scanning.nearbyObjectsDistance,nearbyVehiclesDistance,nearbyPlayersDistance,nearbyPedsDistance) for users who want to decouple scan radius from the render distance, as suggested in the issue.Closes #36.
Test plan
maxInteractDistance.maxInteractDistance(e.g.3.0): entities beyond that range no longer enter the nearby pool.config.nearbyObjectsDistance = 15.0while keepingmaxInteractDistance = 5.0: object interactions scan at 15m, render still gated by 5m.