Skip to content

Add the fanSpeedPercent capability to specific devices #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add the fanSpeedPercent capability to specific devices #2342

wants to merge 2 commits into from

Conversation

Fy-atto7
Copy link

@Fy-atto7 Fy-atto7 commented Aug 15, 2025 •
edited
Loading

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

We have a thermostat device that needs to add the ”fanSpeedPercent“ capability, so we made special modifications for it.

Summary of Completed Tests

We added Unit Test and tested with real device.

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

vangoran
vangoran approved these changes Sep 2, 2025
View reviewed changes
Copy link

@vangoran vangoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

drivers/SmartThings/matter-thermostat/src/init.lua
table.insert(main_component_capabilities, capabilities.fanMode.ID)
for _, p in ipairs(THERMOSTAT_SUPPORTED_PERCENT_PRODUCTS) do
if device.manufacturer_info.vendor_id == p[1] and device.manufacturer_info.product_id == p[2] then
table.insert(main_component_capabilities, capabilities.fanSpeedPercent.ID)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional capability support for specific vendor's product (under CN WWST program)

@Huangxiangjie Huangxiangjie mentioned this pull request Sep 12, 2025
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vangoran vangoran vangoran approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fy-atto7 @CLAassistant @vangoran