refactor: extract duplicated transaction-building logic in StellarService#146
Merged
Smartdevs17 merged 2 commits intoSmartdevs17:mainfrom Mar 27, 2026
Conversation
…buildTransaction (Smartdevs17#28) - Add private buildTransaction() method with shared tx-building logic - buildUnsignedTransaction() now delegates to buildTransaction() - Eliminates code duplication while preserving public API - All tests pass
|
@DevSolex is attempting to deploy a commit to the smartdevs17's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@DevSolex Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #28
Extracts the duplicated transaction-building logic from
buildUnsignedTransaction()into a privatebuildTransaction()method inapi/src/services/stellar.service.ts.Changes
buildTransaction(operation, userAddress, assetAddress, amount)containing the shared tx-building logicbuildUnsignedTransaction()now delegates to it, retaining only error handlingAcceptance Criteria
buildTransactionmethod handles all operationsbuildUnsignedTransactiondelegates to it