Skip to content

refactor: extract duplicated transaction-building logic in StellarService #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Smartdevs17 merged 2 commits into from
Mar 27, 2026
Merged

refactor: extract duplicated transaction-building logic in StellarService #146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c45d246
refactor: extract duplicated transaction-building logic into private …
DevSolex Mar 27, 2026
97a99e7
Merge branch 'main' into refactor/extract-transaction-building-logic-28
Smartdevs17 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 27 additions & 18 deletions api/src/services/stellar.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,32 +50,41 @@ export class StellarService {
}
}

async buildUnsignedTransaction(
private async buildTransaction(
operation: LendingOperation,
userAddress: string,
assetAddress: string | undefined,
amount: string
): Promise<string> {
try {
const account = await this.getAccount(userAddress);
const contract = new Contract(this.contractId);
const account = await this.getAccount(userAddress);
const contract = new Contract(this.contractId);

const params = [
new Address(userAddress).toScVal(),
assetAddress ? new Address(assetAddress).toScVal() : xdr.ScVal.scvVoid(),
nativeToScVal(BigInt(amount), { type: 'i128' }),
];

const params = [
new Address(userAddress).toScVal(),
assetAddress ? new Address(assetAddress).toScVal() : xdr.ScVal.scvVoid(),
nativeToScVal(BigInt(amount), { type: 'i128' }),
];
const tx = new TransactionBuilder(account, {
fee: BASE_FEE,
networkPassphrase: this.networkPassphrase,
})
.addOperation(contract.call(CONTRACT_METHODS[operation], ...params))
.setTimeout(TX_TIMEOUT_SECONDS)
.build();

const tx = new TransactionBuilder(account, {
fee: BASE_FEE,
networkPassphrase: this.networkPassphrase,
})
.addOperation(contract.call(CONTRACT_METHODS[operation], ...params))
.setTimeout(TX_TIMEOUT_SECONDS)
.build();
const preparedTx = await this.sorobanServer.prepareTransaction(tx);
return preparedTx.toXDR();
}

const preparedTx = await this.sorobanServer.prepareTransaction(tx);
return preparedTx.toXDR();
async buildUnsignedTransaction(
operation: LendingOperation,
userAddress: string,
assetAddress: string | undefined,
amount: string
): Promise<string> {
try {
return await this.buildTransaction(operation, userAddress, assetAddress, amount);
} catch (error) {
logger.error(`Failed to build unsigned ${operation} transaction:`, error);
throw new InternalServerError(`Failed to build ${operation} transaction`);
Expand Down
Loading