Open
Conversation
FilledStacks
requested changes
Dec 13, 2024
Contributor
FilledStacks
left a comment
FilledStacks
left a comment
There was a problem hiding this comment.
The code changes looks good.
Just need to know why library is added to the files containing contants.
| @@ -1,4 +1,5 @@ | |||
| /// Stores all the commands used throughout the app that | |||
| library; | |||
Contributor
There was a problem hiding this comment.
Why is the library keyword added to this file, and the same for the one below?
Contributor
Author
There was a problem hiding this comment.
Se my other PR for Offline mode, I've answered there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves Stacked-Org/stacked#1146 and resolves Stacked-Org/stacked#1147
In regards to malformed file fix: the only time the modified function runs is when running stacked compile. Hence no possibility that I can see of it breaking something else. The result is that the compiled_templates.dart always has unix path separators, which it already did on main so no change there.
I've tested running the create view in a sandbox project i have and it works without issue.
In regards to new flag:
There might be another way to make _notifyNewVersion work. Just seems dumb to make it work in a situation where it has no usefullness, thought adding the option to disable it via a flag seemed better.