Add syslog identification on connect#21
Merged
SteveEasley merged 2 commits intoSteveEasley:mainfrom Apr 5, 2026
Merged
Conversation
Send SEND_TO_SYSLOG command during Device.connect() to register pykaleidescape in the Kaleidescape system log, enabling support troubleshooting per the Control Protocol Reference Manual (p. 59). Closes SteveEasley#1 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verify that Device.connect() sends the SEND_TO_SYSLOG command with the correct module name and version string. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Closed
SteveEasley
reviewed
Apr 5, 2026
Owner
SteveEasley
left a comment
SteveEasley
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for closing that one out!
SteveEasley
approved these changes
Apr 5, 2026
robotdan
added a commit
to robotdan/pykaleidescape
that referenced
this pull request
Apr 6, 2026
PR SteveEasley#21 used importlib.metadata.version() to look up the package version at runtime for the syslog identification message. This fails with PackageNotFoundError in PyInstaller deployments because PyInstaller strips dist-info metadata by default. kaleidescape.__version__ is the actual source of truth for the version (pyproject.toml reads from it via setuptools.dynamic), and works in all environments — pip installs, git URL installs, and PyInstaller bundles. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
robotdan
added a commit
to robotdan/pykaleidescape
that referenced
this pull request
Apr 6, 2026
PR SteveEasley#21 used importlib.metadata.version() to look up the package version at runtime for the syslog identification message. This fails with PackageNotFoundError in PyInstaller deployments because PyInstaller strips dist-info metadata by default. kaleidescape.__version__ is the actual source of truth for the version (pyproject.toml reads from it via setuptools.dynamic), and works in all environments — pip installs, git URL installs, and PyInstaller bundles. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SteveEasley
pushed a commit
that referenced
this pull request
May 6, 2026
PR #18 (Refresh device state after auto-reconnect) added two tests that wait on `connect_signal` (STATE_CONNECTED) after the initial connect. PR #19 (Dispatch STATE_CONNECTED only on auto-reconnect) then moved the STATE_CONNECTED dispatch out of `_connect()` and into `_reconnect()`. PR #19 updated other tests with the same pattern, but #19 was opened before #18 merged, so the two tests added by #18 weren't updated. Result: `await connect_signal.wait()` after initial connect waits forever, hanging CI for the full 6h job timeout. Every CI run on main since #18 has been cancelled this way (#19, #20, #21, v1.1.6, #22). Match the pattern used by other tests updated in #19: assert `state == STATE_CONNECTED` directly after the initial connect, and keep `connect_signal.wait()` only for the post-reconnect signal where STATE_CONNECTED is actually dispatched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SEND_TO_SYSLOG:INFORMATION:pykaleidescape version X.Y.Z:duringDevice.connect()to register the module in the Kaleidescape system logCloses #1
Changes
const.py: AddSEND_TO_SYSLOGconstantmessage.py: AddSendToSyslogrequest classdevice.py: CallSEND_TO_SYSLOGat end ofDevice.connect()tests/emulator.py: Addreceived_requeststracking, register mock handler forSEND_TO_SYSLOGtests/test_d_device.py: Addtest_connect_sends_syslog_identificationverifying the command is sent with correct fields