Configurable warnings and capabilities#715
Draft
Theophile-Madet wants to merge 14 commits intomasterfrom
Draft
Conversation
This reverts commit 47f3d3c.
gnunicorn
approved these changes
Nov 21, 2025
gnunicorn
left a comment
gnunicorn
left a comment
There was a problem hiding this comment.
Seems fine to me, but I can't really say much about the tsx. mainly some nitpicks on the docs
tapir/coop/migrations/0056_alter_draftuser_preferred_language_and_more.py
Outdated
Show resolved
Hide resolved
Comment on lines
+21
to
+23
| DEFAULT_SLOT_ORDER = [ | ||
| "Teamleitung", | ||
| ] |
There was a problem hiding this comment.
Shouldn't this be a settings config?
tapir/shifts/migrations/0076_rename_shiftusercapabilitynew_shiftslotwarning_and_more.py
Outdated
Show resolved
Hide resolved
tapir/shifts/migrations/0076_rename_shiftusercapabilitynew_shiftslotwarning_and_more.py
Outdated
Show resolved
Hide resolved
Contributor
|
@Theophile-Madet , as far as I understand having the "notify me when teamleader has changed" hardcoded is the problem, right? Would the solution being able to choose which slots or qualifications you want to be notified for? |
Collaborator
Author
Yes I think that would be the cleanest way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR that moves the new features from the Rizoma branch to the main one.
There are data migrations in tapir/shifts/migrations/0072_auto_20251120_1642.py and tapir/shifts/migrations/0073_auto_20251120_1642.py so the current SuperCoop shifts and users will keep their capabilities.
There's a lot of small changes in many files, it may not make sense to check everything. If you want to check the main changes, look for the views and the models.
@gnunicorn We can't merge this yet because it conflicts with another feature that @crosspolar did on the master branch, but the changes will be on the side of the other feature so this PR shouldn't change.