Skip to content

Overhaul the Code a Bit#17

Merged
vikaskurapati merged 24 commits intomasterfrom
davschneller/first-slight-overhaul
Apr 24, 2025
Merged

Overhaul the Code a Bit#17
vikaskurapati merged 24 commits intomasterfrom
davschneller/first-slight-overhaul

Conversation

@davschneller
Copy link
Copy Markdown
Contributor

@davschneller davschneller commented Feb 2, 2025

We

  • appy clang-format
  • shorten the license headers
  • re-enable unit tests
  • update the utils module, up to before the latest rework
  • replace the CMake config files by license-compliant ones
  • add a CMake config file

clang-tidy conformacy is still a TODO; and will be done later.

@davschneller davschneller marked this pull request as ready for review April 22, 2025 10:11
@@ -0,0 +1,11 @@
Copyright (c) <year> <owner>.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing year and owner?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's intentional here—the license files in the LICENSES folders are meant more or less as templates to reduce the amount of "differing" licenses due to other copyrighty.

Copy link
Copy Markdown
Collaborator

@Thomas-Ulrich Thomas-Ulrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikaskurapati vikaskurapati merged commit 132da42 into master Apr 24, 2025
48 of 51 checks passed
@davschneller davschneller deleted the davschneller/first-slight-overhaul branch April 24, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants