Add composer.json #8
Open
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Templarian
approved these changes
Oct 9, 2019
Owner
|
There doesn't seem to be much demand for this. I'm leaning toward just closing this PR. |
|
Not a good idea. composer is for PHP, please keep it this way, and use npm for front-end dependencies. |
|
With projects sich as the new https://github.com/symfony/asset-mapper there will be more of a demand for this - it would be very helpful for my use-case already. Can this be considered @Templarian ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a composer.json file, allowing us to require this library as a composer (PHP npm) package.
We'll have to publish this on packagist.org before being able to
composer require mdi/svg.There is literally 0 maintenance once the package is published: you can use GitHub hooks to tell packagist when a new version is published.
@Templarian : I don't know if we can use the
mdi/namespace. A composer package published on packagist already uses it, but I don't know if that means that we cannot use it. We can try - if it does not work, we can still use a package name likematerial-design/svg.