fix(azure): use last_merge_source_commit for PR head SHA#2321
Open
fix(azure): use last_merge_source_commit for PR head SHA#2321
Conversation
The code was using `last_merge_commit` which points to a merge commit (or differs from the source branch head), causing incorrect diff computation. Switch to `last_merge_source_commit` to get the actual source branch tip, with a fallback to `last_merge_commit` when the attribute is unavailable. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Review Summary by QodoFix Azure DevOps PR head SHA to use source commit
WalkthroughsDescription• Fix incorrect PR head SHA computation in Azure DevOps provider • Use last_merge_source_commit instead of last_merge_commit • Add fallback to last_merge_commit for backward compatibility Diagramflowchart LR
A["Azure PR Object"] -->|"Previously used"| B["last_merge_commit<br/>merge commit"]
A -->|"Now uses"| C["last_merge_source_commit<br/>source branch tip"]
C -->|"Fallback to"| B
B --> D["Correct Diff Computation"]
C --> D
File Changes1. pr_agent/git_providers/azuredevops_provider.py
|
Contributor
Code Review by Qodo
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
last_merge_commit(a merge commit) instead oflast_merge_source_commit(the actual source branch head) for the PR head SHA.getattrwith a fallback tolast_merge_committo handle cases wherelast_merge_source_commitis not available.Test plan
head_shabefore/after the fixlast_merge_source_commitisNoneor absent🤖 Generated with Claude Code