Skip to content

Remove redundant Description#917

Merged
ue71603 merged 2 commits intonextfrom
remove_redundant
Jun 10, 2025
Merged

Remove redundant Description#917
ue71603 merged 2 commits intonextfrom
remove_redundant

Conversation

@skinkie
Copy link
Copy Markdown
Contributor

@skinkie skinkie commented Jun 8, 2025

Fix for #562

@skinkie skinkie self-assigned this Jun 8, 2025
@skinkie skinkie added the bug Technical mistake, inconsistency with the documentation, etc. label Jun 8, 2025
@ue71603 ue71603 requested a review from trurlurl June 9, 2025 16:45
@trurlurl trurlurl added the needs documentation update The NeTEx document needs to be updated label Jun 10, 2025
@ue71603 ue71603 merged commit 25ff49b into next Jun 10, 2025
1 check passed
@ue71603 ue71603 deleted the remove_redundant branch June 10, 2025 14:01
Copy link
Copy Markdown
Contributor

@Aurige Aurige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing IsAllowed is ok (it's new), but Description should have been deprecated

<xsd:documentation>How headway value should be displayed to public.</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="Description" type="MultilingualString" minOccurs="0">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one being there for quite a long time, I would have prefer a deprecation (but I agree that it needs to be removed at some point)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Description is also a Double, it still exists.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I know this ... but it will not be accepted at this positing any more and that will trigger validation errors !

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want a deprecation pull request?

@trurlurl trurlurl added document has been updated NeTEx Document already updated and removed needs documentation update The NeTEx document needs to be updated labels Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Technical mistake, inconsistency with the documentation, etc. document has been updated NeTEx Document already updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants