Skip to content

Remove redundant Description #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ue71603 merged 2 commits into from
Jun 10, 2025
Merged

Remove redundant Description #917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
188964b
Fix most of the errors, except for IsAllowed
skinkie Jun 8, 2025
f2a6aa4
Remove IsAllowed, since it already has been defined in the parent
skinkie Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions xsd/netex_part_2/part2_journeyTimes/netex_deckEntranceAssignment_version.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,6 @@
</xsd:annotation>
<xsd:sequence>
<xsd:element ref="DeckEntranceRef"/>
<xsd:element name="IsAllowed" type="xsd:boolean" minOccurs="0">
<xsd:annotation>
<xsd:documentation>Whether assigment permits or forbids use of TRAIN COMPONENT and / or specified DECK ENTRANCE at specifed stop. </xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="EntranceSetting" type="EntranceSettingEnumeration" minOccurs="0">
<xsd:annotation>
<xsd:documentation>Default setting for doors when while at stop - are the doors held open, shut or locked shut.</xsd:documentation>
Expand Down
5 changes: 0 additions & 5 deletions xsd/netex_part_2/part2_journeyTimes/netex_vehicleJourneyFrequency_version.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,11 +317,6 @@ Rail transport, Roads and Road transport
<xsd:documentation>How headway value should be displayed to public.</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="Description" type="MultilingualString" minOccurs="0">
Copy link
Copy Markdown
Contributor

@Aurige Aurige Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one being there for quite a long time, I would have prefer a deprecation (but I agree that it needs to be removed at some point)

Copy link
Copy Markdown
Contributor Author

@skinkie skinkie Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Description is also a Double, it still exists.

Copy link
Copy Markdown
Contributor

@Aurige Aurige Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I know this ... but it will not be accepted at this positing any more and that will trigger validation errors !

Copy link
Copy Markdown
Contributor Author

@skinkie skinkie Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want a deprecation pull request?

<xsd:annotation>
<xsd:documentation>Text to describe interval.</xsd:documentation>
</xsd:annotation>
</xsd:element>
</xsd:sequence>
</xsd:group>
<!-- ======================================================================= -->
Expand Down