Skip to content

Fix netex_nm_singleJourneyService_version.xsd#924

Merged
skinkie merged 1 commit intonextfrom
fix_singlejourneyreferencesgroup
Jun 23, 2025
Merged

Fix netex_nm_singleJourneyService_version.xsd#924
skinkie merged 1 commit intonextfrom
fix_singlejourneyreferencesgroup

Conversation

@TuThoThai
Copy link
Copy Markdown
Contributor

Missing inclusion of vehicle_support.xsd

See #921 for further details

@TuThoThai TuThoThai added this to the netex_2.0 milestone Jun 21, 2025
@TuThoThai TuThoThai requested review from Aurige, skinkie and ue71603 June 21, 2025 14:56
@TuThoThai TuThoThai added the bug Technical mistake, inconsistency with the documentation, etc. label Jun 21, 2025
@TuThoThai TuThoThai linked an issue Jun 21, 2025 that may be closed by this pull request
@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented Jun 22, 2025

Could you elaborate - for a noob like me - why adding an include fixes your issue?

@TuThoThai
Copy link
Copy Markdown
Contributor Author

Could you elaborate - for a noob like me - why adding an include fixes your issue?

You're def' not a noob! 😅

Each XSD file requires that we start by declaring other packages it builds upon. In this specific case, if we call for VehicleRef, we need to make sure that Vehicle can be found in the dependencies.
Very similarily that in XML files, we check that all xxxRef are declared as xxx either in the same file or related files.

Hope it helps!

@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented Jun 22, 2025

Not yet. Wat is the bug that you have if this is not included? Is this related to XMLSpy or something else?

@TuThoThai
Copy link
Copy Markdown
Contributor Author

Not yet. Wat is the bug that you have if this is not included? Is this related to XMLSpy or something else?

It creates 2 types of bugs:

  • for softwares that "read" the XSD, such as XMLSpy, it is flag as an unauthorized value in the model
  • for some producing a XML file using that part of the XSD, it flags the file as faulty

And, for all who directly generate NeTEx files with code (such as you), it does not change anything. I think.

@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented Jun 22, 2025

Does it happen with xmllint? Do you have an example xml file that fails for you prior to this patch?

@TuThoThai
Copy link
Copy Markdown
Contributor Author

Does it happen with xmllint? Do you have an example xml file that fails for you prior to this patch?

Actually, you are right it might be a XMLSpy related problem as I cannot even save the XML files always getting this error:
Capture d'écran 2025-06-22 161205

Copy link
Copy Markdown
Contributor

@ue71603 ue71603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think it is ok to add it.

@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented Jun 23, 2025

It was more that my recollection of #921 was that there question was to add VehicleRef (or VehicleTypeRef) and the solution of an xsd include was not what I expected.

@skinkie skinkie merged commit b057085 into next Jun 23, 2025
1 check passed
@skinkie skinkie deleted the fix_singlejourneyreferencesgroup branch June 23, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Technical mistake, inconsistency with the documentation, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should SingleJourney relate to VehicleTypeRef and not VehicleRef?

3 participants