Change the shorelineExtension parameter from 0 to 20#29
Open
LucasChollet wants to merge 1 commit intoVBoulenger:masterfrom
Open
Change the shorelineExtension parameter from 0 to 20#29LucasChollet wants to merge 1 commit intoVBoulenger:masterfrom
LucasChollet wants to merge 1 commit intoVBoulenger:masterfrom
Conversation
`snapista` only accept string values so 10 wasn't considered and the default value was used. On a tile covering Rotterdam and Amsterdam, it achieves to remove around 218 detections. This parameter unfortunately has a performance substantial impact, around two minutes on my PC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snapistaonly accept string values so 10 wasn't considered and the default value was used.On a tile covering Rotterdam and Amsterdam, it achieves to remove around 218 detections.
This parameter unfortunately has a performance substantial impact, around two minutes on my PC.
Before:
After:
On the actual generated LandMask:
With shorelineExtension=0, generated in 22s:
With shorelineExtension=20, generated in 170s:
