Skip to content

ap1 launch file pnc#4

Open
obaidmm wants to merge 1 commit intomainfrom
launch-file-test
Open

ap1 launch file pnc#4
obaidmm wants to merge 1 commit intomainfrom
launch-file-test

Conversation

@obaidmm
Copy link
Contributor

@obaidmm obaidmm commented Dec 8, 2025

Merge Request / Pull Request

Summary of Changes

Briefly describe what this MR/PR does and which issue/task it addresses.

Type of Change

  • Bug fix
  • New feature / task
  • Refactor
  • Documentation

Checklist (to be completed before review)

  • Code follows team standards
  • Tested locally
  • Tests added / updated if relevant
  • Documentation updated if relevant
  • CI / checks pass

Related Issue / Task

  • Closes #[issue_number] (if applicable)

Notes / Additional Context

Any context for reviewers (limitations, known issues, future work)

@obaidmm obaidmm requested review from a team as code owners December 8, 2025 23:30
@alyashour
Copy link
Member

@obaidmm is this still needed? I'm confused how is the code for it in the repo but the PR is still in progress.

Copy link
Member

@alyashour alyashour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ap1.launch.py identical to full_system.launch.py? Lowk I like ap1.launch more as a name - if they're the same thing we can delete this and rename ap1. If they're different we can diff them or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants