Conversation
kuznetsss
force-pushed
the
Add_nix_to_prepare_runner
branch
from
25adff8 to
30b87b4
Compare
prepare-runner/action.yml
Outdated
| install_nix: | ||
| description: Whether to install nix on the runner | ||
| default: "false" |
There was a problem hiding this comment.
Let's remove this.
And let's add a test here: https://github.com/XRPLF/actions/blob/main/.github/workflows/test-prepare-runner.yml#L53
kuznetsss
force-pushed
the
Add_nix_to_prepare_runner
branch
2 times, most recently
from
77a8dc6 to
818f321
Compare
kuznetsss
force-pushed
the
Add_nix_to_prepare_runner
branch
from
818f321 to
81aec0a
Compare
kuznetsss
force-pushed
the
Add_nix_to_prepare_runner
branch
from
b929c98 to
1e7a2c2
Compare
kuznetsss
force-pushed
the
Add_nix_to_prepare_runner
branch
from
db6bb4f to
9235abd
Compare
kuznetsss
force-pushed
the
Add_nix_to_prepare_runner
branch
from
9235abd to
da05c33
Compare
| rustc --version | ||
| fi | ||
|
|
||
| # Nix is only available on Linux in the XRPLF CI images |
There was a problem hiding this comment.
It looks like on macos / is mounted as strict read only. Maybe it is possible to grant full disk access to the actions runner, but for now we couldn't install nix on these macos runners.
There was a problem hiding this comment.
Ok, in this case, let's close this PR, since it doesn't change anything in runtime at all.
The nix in images is already verified inside the images, and doing it here doesn't look nice, since we don't install it here at all.
In the future, if we will make nix the environment manager, we'll have to use it for macOS as well, so we'll have to figure out how to make it work properly for our macOS runners.
2 participants
No description provided.