-
Notifications
You must be signed in to change notification settings - Fork 7
Add nix installation to prepare runner #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
30b87b4
Add nix installation
kuznetsss c21753b
Install only for macos
kuznetsss 4e6b8b3
Add test. Always install nix on macos
kuznetsss 81aec0a
Investigate macos issue
kuznetsss 1e7a2c2
Try determinate systems action
kuznetsss 19a260e
Another try
kuznetsss da05c33
Check nix only on linux
kuznetsss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like on macos
/is mounted as strict read only. Maybe it is possible to grant full disk access to the actions runner, but for now we couldn't install nix on these macos runners.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, in this case, let's close this PR, since it doesn't change anything in runtime at all.
The
nixin images is already verified inside the images, and doing it here doesn't look nice, since we don't install it here at all.In the future, if we will make nix the environment manager, we'll have to use it for macOS as well, so we'll have to figure out how to make it work properly for our macOS runners.