Implement basic unit/instance attestation by md4096 · Pull Request #419 · a-sit-plus/valera

md4096 · 2026-01-21T12:25:53Z

Wallet provider configuration screen:

Related:
a-sit-plus/vck#487
a-sit-plus/signum#400

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/WalletConfig.kt

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt

nodh · 2026-02-11T09:00:17Z

Can we also add a configuration property and screen for the URL of the Wallet Provider Backendd?

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/Constants.kt

...src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/InstanceAttestationHelper.kt

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt

...src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/InstanceAttestationHelper.kt

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt

nodh · 2026-02-12T14:25:20Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d15d43b8d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

shared/src/commonMain/kotlin/ui/navigation/WalletNavigation.kt

shared/src/commonMain/kotlin/ui/views/AttestationSettingsView.kt

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/ProvisioningService.kt

chatgpt-codex-connector · 2026-02-26T12:53:45Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

md4096 · 2026-02-26T12:56:05Z

Pipeline failing until https://github.com/a-sit-plus/valera/tree/fix/build-issues merged

nodh · 2026-02-27T08:28:06Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c65fdad93

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

shared/src/commonMain/kotlin/ui/views/AttestationSettingsView.kt

chatgpt-codex-connector · 2026-03-10T11:53:36Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

nodh · 2026-03-11T09:34:09Z

@codex review

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8cd05d66a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

...src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/InstanceAttestationHelper.kt

chatgpt-codex-connector · 2026-03-11T09:41:38Z

shared/src/commonMain/kotlin/ui/views/AttestationSettingsView.kt

+                        LabeledText(text = "${it.payload.expiration}", label = stringResource(Res.string.text_label_attestation_expiration))
+                        LabeledText(text = "${it.payload.eudiWalletInfo?.keyStorageInfo?.storageType}", label = stringResource(Res.string.text_label_attestation_storage_type))
+                    }
+                    if (bufferedUnitAttestation.value == null && bufferedInstanceAttestation.value == null) {


Allow retry when only one attestation preload succeeds

The load button is shown only when both buffers are null, but preloadAttestation() writes instance attestation before requesting unit attestation. If the unit call fails after instance succeeds, the screen ends up with instance != null and unit == null, which hides the button and leaves no in-screen way to retry fetching the missing unit attestation.

Useful? React with 👍 / 👎.

@md4096 sounds valid?

Changed to an "or" logic for now. But i think this whole processing of the attestations gets a major overhaul with a proper wallet provider in place.

chatgpt-codex-connector · 2026-03-11T09:41:38Z

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/AttestationService.kt

+        val instanceAttestation = requestInstanceAttestation()
+        val pop = instanceAttestationHelper.buildProofOfPossession()
+
+        return unitAttestationHelper.requestUnitAttestation(instanceAttestation, pop)


Cache newly requested unit attestations before returning

requestUnitAttestation() checks bufferedUnitAttestation for reuse, but when it fetches a fresh unit attestation it returns it directly without storing it. That means subsequent calls in the same process (for example repeated POP generation without an explicit preload) always re-hit the network instead of reusing the valid token, increasing latency and failure risk under provider throttling.

Useful? React with 👍 / 👎.

@md4096 sounds valid?

Proper key management is part of a subsequent PR

I try to optimize it during the testing now

chatgpt-codex-connector · 2026-03-12T10:01:14Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

md4096 · 2026-03-12T10:05:20Z

Rebased the branch and i am going to retest the whole procedure

chatgpt-codex-connector · 2026-03-12T10:10:37Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector · 2026-03-12T10:13:20Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector · 2026-03-12T11:34:11Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector · 2026-03-12T13:39:08Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector · 2026-03-12T13:41:23Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

nodh · 2026-03-13T09:01:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b90b3b1593

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-13T09:10:59Z

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/AttestationService.kt

+
+
+    fun getWalletProviderHost() = config.walletProviderHost
+    fun setWalletProviderHost(host: String) = config.set(walletProviderHost = host)


Clear attestation cache when wallet-provider host changes

Updating the wallet-provider host currently only persists the new URL, but both attestation caches remain valid and are reused solely by expiration checks. If a user preloads attestations for host A, switches to host B in settings, and then runs attestation-dependent flows, requestInstanceAttestation/requestUnitAttestation can still return host-A tokens until they expire, which can cause mismatched-provider failures (and the settings screen may keep the reload button hidden because buffers are still non-null).

Useful? React with 👍 / 👎.

Seems like a valid improvement

chatgpt-codex-connector · 2026-03-13T09:24:30Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

md4096 self-assigned this Jan 21, 2026

md4096 force-pushed the feature/wia-wua branch from d2b806c to d774927 Compare January 21, 2026 12:27

This was referenced Jan 21, 2026

Add data fields for Instance/Unit Attestation a-sit-plus/signum#400

Merged

Implement basic unit/instance attestation a-sit-plus/vck#487

Open

md4096 force-pushed the feature/wia-wua branch from d774927 to ee64144 Compare January 21, 2026 15:13

md4096 force-pushed the feature/wia-wua branch 2 times, most recently from 5a582a0 to f057199 Compare February 4, 2026 13:40

nodh reviewed Feb 4, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/WalletConfig.kt Show resolved Hide resolved

nodh reviewed Feb 11, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 11, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt Show resolved Hide resolved

md4096 force-pushed the feature/wia-wua branch from ab29586 to 86cbc46 Compare February 11, 2026 14:21

nodh reviewed Feb 11, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/Constants.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 11, 2026

View reviewed changes

...src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/InstanceAttestationHelper.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 11, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 11, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 11, 2026

View reviewed changes

...src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/InstanceAttestationHelper.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 12, 2026

View reviewed changes

...src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/InstanceAttestationHelper.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 12, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt Show resolved Hide resolved

nodh reviewed Feb 12, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 12, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 12, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 12, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 12, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 12, 2026

View reviewed changes

shared/src/commonMain/kotlin/ui/navigation/WalletNavigation.kt Outdated Show resolved Hide resolved

shared/src/commonMain/kotlin/ui/views/AttestationSettingsView.kt Show resolved Hide resolved

md4096 force-pushed the feature/wia-wua branch 3 times, most recently from cc69c21 to a505ac0 Compare February 20, 2026 14:16

nodh reviewed Feb 24, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/ProvisioningService.kt Outdated Show resolved Hide resolved

md4096 marked this pull request as ready for review February 26, 2026 12:53

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

shared/src/commonMain/kotlin/ui/views/AttestationSettingsView.kt Outdated Show resolved Hide resolved

md4096 force-pushed the feature/wia-wua branch from 6c65fda to 48723c5 Compare February 27, 2026 09:54

md4096 requested a review from nodh March 10, 2026 11:47

nodh reviewed Mar 11, 2026

View reviewed changes

shared/src/commonMain/kotlin/at/asitplus/wallet/app/common/attestation/UnitAttestationHelper.kt Show resolved Hide resolved

nodh requested changes Mar 11, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

nodh approved these changes Mar 12, 2026

View reviewed changes

md4096 force-pushed the feature/wia-wua branch from 59076b2 to e00f694 Compare March 12, 2026 10:01

Implement basic unit/instance attestation

a67af1d

md4096 force-pushed the feature/wia-wua branch from fb563c9 to a67af1d Compare March 12, 2026 10:13

Change AttestationService to scoped

e7f1d77

Add unit attestation to buffer

a596aca

Improve error handling for attestation preload

b90b3b1

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

Clear attestation service buffers after host switch

0a95135



		fun getWalletProviderHost() = config.walletProviderHost
		fun setWalletProviderHost(host: String) = config.set(walletProviderHost = host)

Conversation

md4096 commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodh commented Feb 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodh commented Feb 12, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot commented Feb 26, 2026

Uh oh!

md4096 commented Feb 26, 2026

Uh oh!

nodh commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot commented Mar 10, 2026

Uh oh!

nodh commented Mar 11, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

nodh Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

md4096 Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

nodh Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

md4096 Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

md4096 Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot commented Mar 12, 2026

Uh oh!

md4096 commented Mar 12, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 12, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 12, 2026

Uh oh!

md4096 commented Jan 21, 2026 •

edited

Loading