Implement basic unit/instance attestation by md4096 · Pull Request #487 · a-sit-plus/vck

md4096 · 2026-01-21T12:24:59Z

Related:
a-sit-plus/signum#400
a-sit-plus/valera#419

openid-data-classes/src/commonMain/kotlin/at/asitplus/openid/KeyAttestationRequired.kt

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt

openid-data-classes/src/commonMain/kotlin/at/asitplus/openid/KeyAttestationRequired.kt

vck-openid-ktor/src/commonMain/kotlin/at/asitplus/wallet/lib/ktor/openid/OAuth2KtorClient.kt

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oauth2/SimpleAuthorizationService.kt

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/CredentialIssuer.kt

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/ProofValidator.kt

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt

nodh · 2026-02-12T14:25:13Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4d86a20b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oauth2/SimpleAuthorizationService.kt

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/ProofValidator.kt

chatgpt-codex-connector · 2026-02-19T09:39:42Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

nodh · 2026-02-19T11:09:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e46e847869

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

vck-openid-ktor/src/commonMain/kotlin/at/asitplus/wallet/lib/ktor/openid/OAuth2KtorClient.kt

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt

nodh · 2026-02-20T10:08:57Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0f5965ae9f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

vck-openid-ktor/src/commonMain/kotlin/at/asitplus/wallet/lib/ktor/openid/OAuth2KtorClient.kt

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/CredentialIssuer.kt

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt

CHANGELOG.md

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/CredentialIssuer.kt

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt

nodh · 2026-03-11T09:36:08Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b7e42e8e1d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/CredentialIssuer.kt

chatgpt-codex-connector · 2026-03-11T09:43:58Z

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt

        } ?: credentialFormat.supportedProofTypes?.get(ProofTypes.ATTESTATION)?.let {
            createCredentialRequestProofAttestation(clientNonce, it.supportedSigningAlgorithms)


Wire unit attestation into attestation-only proof flow

When metadata exposes only proof_types_supported.attestation, createCredentialRequestProof calls createCredentialRequestProofAttestation(clientNonce, it.supportedSigningAlgorithms) without forwarding unitAttestationPop, so the method falls back to deprecated loadKeyAttestation. This means clients that migrated to the new loadUnitAttestationPop callback still fail with Key attestation required, none provided against attestation-only issuers.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-13T09:41:45Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

nodh · 2026-03-13T09:46:55Z

@codex review

md4096 self-assigned this Jan 21, 2026

This was referenced Jan 21, 2026

Implement basic unit/instance attestation a-sit-plus/valera#419

Open

Add data fields for Instance/Unit Attestation a-sit-plus/signum#400

Merged

md4096 force-pushed the feature/wia-wua branch from 190b492 to 829a0bb Compare January 21, 2026 15:13

nodh reviewed Jan 22, 2026

View reviewed changes

openid-data-classes/src/commonMain/kotlin/at/asitplus/openid/KeyAttestationRequired.kt Outdated Show resolved Hide resolved

nodh reviewed Jan 22, 2026

View reviewed changes

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt Outdated Show resolved Hide resolved

md4096 force-pushed the feature/wia-wua branch from 87158d8 to 8c5dd46 Compare January 22, 2026 12:47

md4096 force-pushed the feature/wia-wua branch from 8c5dd46 to f87d2cc Compare February 3, 2026 13:56

nodh reviewed Feb 3, 2026

View reviewed changes

openid-data-classes/src/commonMain/kotlin/at/asitplus/openid/KeyAttestationRequired.kt Show resolved Hide resolved

nodh reviewed Feb 3, 2026

View reviewed changes

vck-openid-ktor/src/commonMain/kotlin/at/asitplus/wallet/lib/ktor/openid/OAuth2KtorClient.kt Show resolved Hide resolved

nodh reviewed Feb 3, 2026

View reviewed changes

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 3, 2026

View reviewed changes

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt Outdated Show resolved Hide resolved

md4096 force-pushed the feature/wia-wua branch 2 times, most recently from c4550f7 to 8130d1d Compare February 4, 2026 13:44

nodh reviewed Feb 4, 2026

View reviewed changes

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oauth2/SimpleAuthorizationService.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 4, 2026

View reviewed changes

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/CredentialIssuer.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 4, 2026

View reviewed changes

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/ProofValidator.kt Outdated Show resolved Hide resolved

nodh reviewed Feb 4, 2026

View reviewed changes

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt Outdated Show resolved Hide resolved

md4096 force-pushed the feature/wia-wua branch from 156f8f7 to ce57bdf Compare February 11, 2026 13:55

chatgpt-codex-connector bot reviewed Feb 12, 2026

View reviewed changes

md4096 force-pushed the feature/wia-wua branch from c4d86a2 to ed51cba Compare February 19, 2026 09:37

md4096 marked this pull request as ready for review February 19, 2026 09:39

md4096 force-pushed the feature/wia-wua branch 2 times, most recently from 5657425 to e46e847 Compare February 19, 2026 09:59

chatgpt-codex-connector bot reviewed Feb 19, 2026

View reviewed changes

vck-openid-ktor/src/commonMain/kotlin/at/asitplus/wallet/lib/ktor/openid/OAuth2KtorClient.kt Outdated Show resolved Hide resolved

vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt Outdated Show resolved Hide resolved

md4096 force-pushed the feature/wia-wua branch 2 times, most recently from 38b704f to 49bf8e8 Compare February 20, 2026 09:44

md4096 force-pushed the feature/wia-wua branch from 49bf8e8 to 0f5965a Compare February 20, 2026 09:57

chatgpt-codex-connector bot reviewed Feb 20, 2026

View reviewed changes

nodh requested changes Feb 20, 2026

View reviewed changes

md4096 force-pushed the feature/wia-wua branch 4 times, most recently from dda5b98 to 11d743e Compare February 20, 2026 15:02

nodh added this to the 5.12.0 milestone Feb 24, 2026

md4096 force-pushed the feature/wia-wua branch from 11d743e to d5f0206 Compare February 26, 2026 12:53

md4096 requested a review from nodh February 27, 2026 09:41

This was referenced Feb 27, 2026

JWK should be omitted if key attestation is set + kid 0 is missing #521

Closed

WalletService loadKeyAttestation raw format #523

Closed

md4096 force-pushed the feature/wia-wua branch from d5f0206 to b7e42e8 Compare March 3, 2026 09:51

nodh approved these changes Mar 11, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

Implement basic unit/instance attestation

99ee163

md4096 force-pushed the feature/wia-wua branch from b7e42e8 to 99ee163 Compare March 13, 2026 09:41

		} ?: credentialFormat.supportedProofTypes?.get(ProofTypes.ATTESTATION)?.let {
		createCredentialRequestProofAttestation(clientNonce, it.supportedSigningAlgorithms)

Conversation

md4096 commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodh commented Feb 12, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot commented Feb 19, 2026

Uh oh!

nodh commented Feb 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

nodh commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodh commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot commented Mar 13, 2026

Uh oh!

nodh commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

md4096 commented Jan 21, 2026 •

edited

Loading