Merged
Conversation
This was referenced Mar 25, 2026
Collaborator
Author
This was referenced Mar 25, 2026
0xAndoroid
force-pushed
the
jolt-v2/jolt-field
branch
from
74305c7 to
17e1d5d
Compare
0xAndoroid
force-pushed
the
jolt-v2/jolt-field
branch
3 times, most recently
from
15bbf97 to
327de42
Compare
0xAndoroid
force-pushed
the
jolt-v2/jolt-profiling
branch
from
0a58fef to
240e60c
Compare
Contributor
|
Warning This PR has more than 500 changed lines and does not include a spec. Large features and architectural changes benefit from a spec-driven workflow. If this PR is a bug fix, refactor, or doesn't warrant a spec, feel free to ignore this message. |
Remove duplicate [workspace.lints.clippy] section introduced by rebase, add workspace lint inheritance to jolt-profiling, bump sysinfo to workspace version, and fix all lint violations.
0xAndoroid
reviewed
Apr 3, 2026
Collaborator
0xAndoroid
left a comment
0xAndoroid
left a comment
There was a problem hiding this comment.
7 issues found after deduplication across semantic, bug, tech-debt, and security review passes. Two earlier issues (missing workspace lints, sysinfo version mismatch) were fixed in b003fba.
Contributor
Benchmark comparison (crates) |
- Use System::new() + refresh_cpu_all() instead of new_all()/refresh_all() - Fix format_memory_size for negative deltas (use abs comparison) - Use BYTES_PER_MIB directly in flamegraph factor - Drop first mutex before acquiring second in end_memory_tracing_span - Clamp monitor interval to 50ms minimum - Re-export flamegraph functions at crate root - Use Acquire/Release ordering for monitor stop flag
Contributor
Benchmark comparison (crates) |
Contributor
Benchmark comparison (crates) |
Contributor
Benchmark comparison (crates) |
Downstream crates no longer need #[cfg] gates at every call site.
0xAndoroid
force-pushed
the
jolt-v2/jolt-profiling
branch
from
701407e to
9bb5294
Compare
Contributor
Benchmark comparison (crates) |
Mutex locks recover from poisoning via into_inner. PprofGuard::new and MetricsMonitor::start log warnings on failure instead of panicking.
Contributor
Benchmark comparison (crates) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Testing
cargo clippyandcargo fmtpassSecurity Considerations
Breaking Changes
None