Merged
Conversation
This was referenced Mar 25, 2026
Collaborator
Author
This was referenced Mar 25, 2026
markosg04
requested review from
0xAndoroid,
moodlezoup and
sagar-a16z
as code owners
0xAndoroid
force-pushed
the
jolt-v2/jolt-profiling
branch
from
0a58fef to
240e60c
Compare
0xAndoroid
changed the base branch from
jolt-v2/jolt-profiling
to
graphite-base/1365
0xAndoroid
force-pushed
the
jolt-v2/jolt-transcript
branch
from
f089b0c to
9d859ae
Compare
0xAndoroid
force-pushed
the
jolt-v2/jolt-transcript
branch
from
9d859ae to
141bc87
Compare
- Add #[expect(clippy::expect_used)] for infallible Poseidon operations - Replace deprecated criterion::black_box with std::hint::black_box
Contributor
|
Warning This PR has more than 500 changed lines and does not include a spec. Large features and architectural changes benefit from a spec-driven workflow. If this PR is a bug fix, refactor, or doesn't warrant a spec, feel free to ignore this message. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Benchmark comparison (crates) |
…idon, and API improvements - Add absorb/squeeze domain separation tags (0x00/0x01 for hash-based, even/odd round encoding for Poseidon) to prevent operation conflation - Cache Poseidon<Fr> instance as struct field to avoid per-hash allocation of round constants - Add length-encoding step to Poseidon multi-chunk append to disambiguate inputs differing only in trailing zeros - Make Default delegate to new(b"") for domain separation on default transcripts - Expand Challenge associated type bounds with PartialEq, Eq, Debug, Hash - Fix Poseidon doc: "width-3" -> "3-input (width-4 permutation)" - Move digest and light-poseidon to workspace dependencies - Add PoseidonTranscript to benchmarks and fuzz target - Merge README.md into lib.rs crate-level docs - Remove REVIEW.md and README.md
Contributor
Benchmark comparison (crates) |
- Use workspace dep for jolt-field instead of path - Remove crate-level lint attrs that duplicate workspace lints - Use #[expect(unused_results)] in benches per lint policy
Contributor
Benchmark comparison (crates) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Testing
cargo clippyandcargo fmtpassSecurity Considerations
Breaking Changes
None