Don't lock threads #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On v1.3 if you are opening paths the I/O was made thread-safe by default, but if you don't need thread-safety it can be faster to ignore the I/O locks. See JuliaLang/julia#34195 for details. This fixes the performance post v1.3: Before: ```julia 689.599 μs (15 allocations: 347.34 KiB) ``` After: ```julia 243.900 μs (15 allocations: 347.34 KiB) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On v1.3 if you are opening paths the I/O was made thread-safe by default, but if you don't need thread-safety it can be faster to ignore the I/O locks. See JuliaLang/julia#34195 for details. This fixes the performance post v1.3:
Before:
After: