Skip to content

[FEATURE 860] Setting to disable display of "What's New"#880

Merged
accius merged 2 commits intoaccius:Stagingfrom
alanhargreaves:860-whatsnew
Apr 5, 2026
Merged

[FEATURE 860] Setting to disable display of "What's New"#880
accius merged 2 commits intoaccius:Stagingfrom
alanhargreaves:860-whatsnew

Conversation

@alanhargreaves
Copy link
Copy Markdown
Collaborator

What does this PR do?

Adds a setting to disable the automatic display of the "What's New" panel.

Adds an entry for "Rig Bridge" in the side panel settings.

Type of change

  • Bug fix
  • New feature
  • Performance improvement
  • Refactor / code cleanup
  • Documentation
  • Translation
  • Map layer plugin

How to test

  1. Edit your openhamclock_lastSeenVersion setting in your local storage to set it to 26.1.3.
  2. Reload your browser session. The "What's New Page" should display as the setting defaults to true.
  3. Go to "Display Settings" and toggle the setting for "Show What's New on Startup" to be unchecked.
  4. Save the settings.
  5. Edit your openhamclock_lastSeenVersion setting in your local storage to set it to 26.1.3.
  6. Reload your browser session. The "What's New Page" should not display.
  7. Reset your "Show What's New on Startup" to be true if that's what you want.
  8. Click the version number on the top left of the screen and the latest "What's New" should still display.
  9. Open the Side Panel. You should see an entry for "Rig Bridge".
  10. Click it to verify that the correct Settings screen is displayed.

Checklist

  • App loads without console errors
  • Tested in Dark, Light, and Retro themes
  • Responsive at different screen sizes (desktop + mobile)
  • If touching server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)
  • If adding an API route: includes caching and error handling
  • If adding a panel: wired into Modern, Classic, and Dockable layouts
  • No hardcoded colors — uses CSS variables (var(--accent-cyan), etc.)
  • No .bak, .old, console.log debug lines, or test scripts included

@alanhargreaves
Copy link
Copy Markdown
Collaborator Author

fixes 860

@alanhargreaves
Copy link
Copy Markdown
Collaborator Author

#860

@alanhargreaves alanhargreaves linked an issue Apr 5, 2026 that may be closed by this pull request
11 tasks
Copy link
Copy Markdown
Owner

@accius accius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean PR — good scope. A few things to fix before merge:

Direct config mutation in onChange — The checkbox handler mutates config directly AND sets React state:

config.showWhatsNew = e.target.checked;
setShowWhatsNew(e.target.checked);

The rest of the settings panel sets local state and persists on Save. This means the setting takes effect immediately even without saving, and the behavior on reload without saving is ambiguous. Should follow the same pattern as other settings.

showWhatsNew not in the save handler — I don't see it added to the config object built in the save function. It may work via the direct mutation, but if the user reloads without saving, the setting could revert. Add it alongside the other config fields in the save handler.

"Rig Bridge" label not i18n'd — The sidebar entry uses a hardcoded 'Rig Bridge' string while all other entries use t('...') translation keys.

Helper text wording — "Setting this true means it will only be displayed when the version is clicked" reads a bit backwards since unchecking the box is what disables it. Suggest: "When unchecked, What's New will only appear when you click the version number."

@accius accius merged commit 6cb4481 into accius:Staging Apr 5, 2026
4 checks passed
@alanhargreaves alanhargreaves deleted the 860-whatsnew branch April 5, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Setting to disable display of "What's New"

2 participants