[FEATURE 860] Setting to disable display of "What's New"#880
[FEATURE 860] Setting to disable display of "What's New"#880accius merged 2 commits intoaccius:Stagingfrom
Conversation
|
fixes 860 |
accius
left a comment
There was a problem hiding this comment.
Nice and clean PR — good scope. A few things to fix before merge:
Direct config mutation in onChange — The checkbox handler mutates config directly AND sets React state:
config.showWhatsNew = e.target.checked;
setShowWhatsNew(e.target.checked);The rest of the settings panel sets local state and persists on Save. This means the setting takes effect immediately even without saving, and the behavior on reload without saving is ambiguous. Should follow the same pattern as other settings.
showWhatsNew not in the save handler — I don't see it added to the config object built in the save function. It may work via the direct mutation, but if the user reloads without saving, the setting could revert. Add it alongside the other config fields in the save handler.
"Rig Bridge" label not i18n'd — The sidebar entry uses a hardcoded 'Rig Bridge' string while all other entries use t('...') translation keys.
Helper text wording — "Setting this true means it will only be displayed when the version is clicked" reads a bit backwards since unchecking the box is what disables it. Suggest: "When unchecked, What's New will only appear when you click the version number."
What does this PR do?
Adds a setting to disable the automatic display of the "What's New" panel.
Adds an entry for "Rig Bridge" in the side panel settings.
Type of change
How to test
openhamclock_lastSeenVersionsetting in your local storage to set it to26.1.3.openhamclock_lastSeenVersionsetting in your local storage to set it to26.1.3.Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts included