Skip to content

Comments

Fix convertJs export#6

Open
terrierscript wants to merge 1 commit intoacdlite:masterfrom
terrierscript:convert-js-module
Open

Fix convertJs export#6
terrierscript wants to merge 1 commit intoacdlite:masterfrom
terrierscript:convert-js-module

Conversation

@terrierscript
Copy link

Fix #5

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should be exporting it, I believe. I wonder if line 24 is causing isses with it. Babel handles translating ES6 module syntax to requirejs.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's an issue with how babel exports things with only a default or with a default and other properties: http://babeljs.io/docs/usage/modules/#interop
(Or not quite an issue, it's by design). Anyway, I have a different fix for it in #9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants