update export and change to map iteration#9
Closed
gkatsev wants to merge 2 commits intoacdlite:masterfrom
Closed
Conversation
Array iterations is a high level concept that requires the use of Symbols. Symbols aren't avaiable everywhere and regular maps are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this way of handling the exports is better because it keeps it all within babel and doesn't leak the underlying module system into the code.
As for not using array comprehensions, I think that it's not quite necessary and makes the versions of node that this works on wider as it doesn't require the Symbol polyfill. In addition, it's probably easier to understand a
Array#mapthan an array comprehension.