Disable interrupts conditionally#102
Merged
ladyada merged 5 commits intoadafruit:masterfrom Apr 22, 2025
Merged
Conversation
Contributor
Author
|
@ladyada more of a hack than a fix, but for review... |
Contributor
Author
|
Also tested with a Metro ESP32-S2: |
Member
|
lets try it! plz bump release |
This was referenced Jun 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a nominal fix for the issue raised in this forum post:
https://forums.adafruit.com/viewtopic.php?t=217653
It does not fix interrupt playback. It simply protects from unnecessarily disabling interrupts if not using interrupt based playback, which prevented even non-interrupt playback from working.
Tested with an Arduino Giga R1 using the
player_simpleexample from this library - modified for shield pins and commenting out call tomusicPlayer.useInterrupt(). The call toplayFullFile()now works, but notstartPlayingFile(), etc.