Skip to content

FORMS-18722: Active user interface component lacks 3 to 1 contrast ratio @sunnym @vavarshn#39

Closed
CezarSTF wants to merge 2 commits intomainfrom
ens83070/FORMS-18722
Closed

FORMS-18722: Active user interface component lacks 3 to 1 contrast ratio @sunnym @vavarshn#39
CezarSTF wants to merge 2 commits intomainfrom
ens83070/FORMS-18722

Conversation

@CezarSTF
Copy link
Copy Markdown
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CezarSTF
Copy link
Copy Markdown
Collaborator Author

Before:
image
After:
image

display: flex;
align-items: center;
justify-content: center;
border: 1px solid $light-gray;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CezarSTF The change looks fine, but please check if changing to this color is making checkbox look very different from radio buttons or not?(also what is contrast ratio for radio button then) . Ideally, we should have same border colors for these.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @akshayvas !
Yes, the checkbox border contrast doesn't match the radio buttons contrast, (radio button group contrast is 1.29:1), should I change the contrast to the radio button group too?
Please let me know how to proceed.
image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CezarSTF Yes, both should have same border, otherwise it might seem that radio button is in some other state

@CezarSTF
Copy link
Copy Markdown
Collaborator Author

@akshayvas
Here's a screenshot of how the radio buttons look now
image

@CezarSTF
Copy link
Copy Markdown
Collaborator Author

The ticket is fixed by this PR ( https://github.com/adobe/aem-forms-theme-wknd/pull/40/files ). Closing

@CezarSTF CezarSTF closed this Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants