Skip to content

FORMS-18722: Active user interface component lacks 3 to 1 contrast ratio @sunnym @vavarshn #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CezarSTF wants to merge 2 commits into from
Closed

FORMS-18722: Active user interface component lacks 3 to 1 contrast ratio @sunnym @vavarshn #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83132e6
FORMS-18722: Active user interface component lacks 3 to 1 contrast ra…
CezarSTF Jun 24, 2025
57637fb
FORMS-18722: Desktop, RWD Tablet, RWD Mobile - Text content lacks 4.5…
CezarSTF Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/checkboxgroup/_checkboxgroup.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
display: flex;
align-items: center;
justify-content: center;
border: 1px solid $light-gray;
Copy link
Copy Markdown
Contributor

@akshayvas akshayvas Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CezarSTF The change looks fine, but please check if changing to this color is making checkbox look very different from radio buttons or not?(also what is contrast ratio for radio button then) . Ideally, we should have same border colors for these.

Copy link
Copy Markdown
Collaborator Author

@CezarSTF CezarSTF Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @akshayvas !
Yes, the checkbox border contrast doesn't match the radio buttons contrast, (radio button group contrast is 1.29:1), should I change the contrast to the radio button group too?
Please let me know how to proceed.
image

Copy link
Copy Markdown
Contributor

@akshayvas akshayvas Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CezarSTF Yes, both should have same border, otherwise it might seem that radio button is in some other state

}

&__label:hover input[type='checkbox'] {
Expand Down
1 change: 1 addition & 0 deletions src/components/radiobutton/_radiobutton.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
display: flex;
align-items: center;
justify-content: center;
border: 1px solid $light-gray;
padding: 5px;
height: 1.1rem;
width: 1.1rem;
Expand Down