Add functions to emit and listen events of inspector#718
Closed
gregogalante wants to merge 1 commit intoaframevr:masterfrom
gregogalante:master
Closed
Add functions to emit and listen events of inspector#718gregogalante wants to merge 1 commit intoaframevr:masterfrom gregogalante:master
gregogalante wants to merge 1 commit intoaframevr:masterfrom
gregogalante:master
Conversation
Contributor
|
There is already Line 20 in 575c910 We can just add this.off = Events.off; instead of using two other functions.Please don't include the dist in the PR. |
Contributor
|
Ah and |
Author
|
@vincentfretin this.emit = Events.emit is not existing. I create a new pull request |
Contributor
|
Yeah this is what I meant, change your PR to expose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes we need to manage inspector functionalities from the outside. We can access with AFRAME.INSPECTOR but some operations can not be done with the Inspector class instance.
With this mode we can listen and emit events using AFRAME.INSPECTOR.