Skip to content

Add functions to emit and listen events of inspector#718

Closed
gregogalante wants to merge 1 commit intoaframevr:masterfrom
gregogalante:master
Closed

Add functions to emit and listen events of inspector#718
gregogalante wants to merge 1 commit intoaframevr:masterfrom
gregogalante:master

Conversation

@gregogalante
Copy link

Sometimes we need to manage inspector functionalities from the outside. We can access with AFRAME.INSPECTOR but some operations can not be done with the Inspector class instance.

With this mode we can listen and emit events using AFRAME.INSPECTOR.

@vincentfretin
Copy link
Contributor

There is already

this.on = Events.on;
exposed
We can just add this.off = Events.off; instead of using two other functions.
Please don't include the dist in the PR.

@vincentfretin
Copy link
Contributor

Ah and this.emit = Events.emit of course.

@gregogalante
Copy link
Author

@vincentfretin this.emit = Events.emit is not existing. I create a new pull request

@vincentfretin
Copy link
Contributor

Yeah this is what I meant, change your PR to expose off and emit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants