[cleanup] Remove exposed on/emit/off that were not working properly#755
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Aug 29, 2024
Merged
Conversation
…bad binding so not used in the wild
Member
|
Thanks |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove exposed on/emit/off that were not working properly because of bad binding (see #754 for an explanation) so not used in the wild.
The
this.onwas there a long time ago, we introduced thethis.offandthis.emitin #719 but those weren't working.@gregogalante you can still do your own build with #754 changes if you need that.
Instead of exposing the events publicly, let's keep it internal for now.
I want later to define documented commands that can be used instead (undo compatible).