Added this.emit = Events.emit to add possibility to emit custom events from outside the Inspector class.#719
Merged
dmarcos merged 2 commits intoaframevr:masterfrom Jun 12, 2024
gregogalante:master
Merged
Added this.emit = Events.emit to add possibility to emit custom events from outside the Inspector class.#719dmarcos merged 2 commits intoaframevr:masterfrom gregogalante:master
dmarcos merged 2 commits intoaframevr:masterfrom
gregogalante:master
Conversation
Added this.emit = Events.emit to add possibility to emit custom events from outside the Inspector class.
Contributor
|
It would make sense to also expose |
Contributor
|
I would be interested of knowing your use case with this, creating entity with the entitycreate event maybe? You can DM me on discord (handle vincentfretin) for a quick chat. |
Member
|
Thanks so much. Congrats on your first contribution @gregogalante |
Contributor
|
Did you forgot to push the Merge button @dmarcos? |
Member
|
thanks |
Contributor
|
This was not working. It will be reverted in #755 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added this.emit = Events.emit to add possibility to emit custom events from outside the Inspector class.