[bugfix] Properly bind the exposed on/off/emit functions#754
Closed
vincentfretin wants to merge 1 commit intoaframevr:masterfrom
Closed
[bugfix] Properly bind the exposed on/off/emit functions#754vincentfretin wants to merge 1 commit intoaframevr:masterfrom
vincentfretin wants to merge 1 commit intoaframevr:masterfrom
Conversation
…n event emitted with AFRAME.INSPECTOR.emit is correctly catched in an Events.on listener
Contributor
Author
|
Closed in favor of #755 |
Contributor
Author
|
I reverted the above mentioned change in 3dstreet and did this instead 3DStreet/3dstreet@5ac90b7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure the exposed
on/off/emitonInspectorare bound toEventsso an event emitted withAFRAME.INSPECTOR.emitis correctly catched in anEvents.onlistener, otherwise it's using two different registries and doesn't work.And example of usage of emit externally for a component to trigger the update of the scene graph.
3DStreet/3dstreet@6990401