fix: disable logout on GET to prevent CSRF logout attacks#990
fix: disable logout on GET to prevent CSRF logout attacks#990ankushchk wants to merge 1 commit intoalphaonelabs:mainfrom
Conversation
👀 Peer Review RequiredHi @ankushchk! This pull request does not yet have a peer review. Before this PR can be merged, please request a review from one of your peers:
Thank you for contributing! 🎉 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
WalkthroughA configuration setting in web/settings.py has been updated, changing ACCOUNT_LOGOUT_ON_GET from True to False with accompanying comments explaining the CSRF risk mitigation rationale. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Related issues
ACCOUNT_LOGOUT_ON_GET = Trueallows any website to silently log out alogged-in user by embedding a simple
<image>tag:Checklist
Summary by CodeRabbit