Skip to content

fix: disable logout on GET to prevent CSRF logout attacks #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankushchk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: disable logout on GET to prevent CSRF logout attacks #990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion web/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,9 @@
ACCOUNT_REMEMBER_ME_FIELD = "remember" # Match test field name
ACCOUNT_LOGIN_ON_PASSWORD_RESET = True
ACCOUNT_SIGNUP_PASSWORD_ENTER_TWICE = False
ACCOUNT_LOGOUT_ON_GET = True
# SECURITY: Must be False. Setting True allows any page to log out users
# via a GET request (e.g. <img src="/accounts/logout/">), a CSRF attack vector.
ACCOUNT_LOGOUT_ON_GET = False
ACCOUNT_SIGNUP_EMAIL_ENTER_TWICE = False
ACCOUNT_LOGOUT_ON_PASSWORD_CHANGE = False
ACCOUNT_OLD_PASSWORD_FIELD_ENABLED = True
Expand Down