Skip to content

Revert unintended changes for alpine#246

Merged
Taka-Kazu merged 4 commits intoalpine-custom-apkfrom
revert-unintended-changes-for-alpine
Mar 31, 2026
Merged

Revert unintended changes for alpine#246
Taka-Kazu merged 4 commits intoalpine-custom-apkfrom
revert-unintended-changes-for-alpine

Conversation

@Taka-Kazu
Copy link
Copy Markdown

Changed by #244

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the Infrastructure General channel on our Zulip server.


For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep

For changes related to yamllint:

  • ❌ One or more linter violations were added to YAML files

Comment thread rosdep/base.yaml
rhel: [cppunit-devel]
slackware: [cppunit]
ubuntu: [libcppunit-dev]
croncpp:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line does not pass YAML linter checks: wrong ordering of key "cpuburn" in mapping

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@Taka-Kazu Taka-Kazu requested a review from f-fl0 March 31, 2026 02:44
@Taka-Kazu Taka-Kazu merged commit 2736692 into alpine-custom-apk Mar 31, 2026
4 checks passed
@Taka-Kazu Taka-Kazu deleted the revert-unintended-changes-for-alpine branch March 31, 2026 04:04
@at-wat at-wat mentioned this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants