Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Conversation

@snikch
Copy link
Contributor

@snikch snikch commented Mar 14, 2013

I know you've changed a large amount of the file structure in your repo, but I thought you might like to pick out the password commit, so that password fields can correctly have a placeholder applied.

Cheers

@snikch
Copy link
Contributor Author

snikch commented Mar 14, 2013

Urgh, that commit doesn't look very nice, vim appears to have messed with all the spacing. The main change is a new class in the settings, then a check in both the focus and blur events.

@andrewrjones
Copy link
Owner

Hi Mal,

I finally got a chance to look at this. Running both our codes through the same beautifier helped me pick out the changes.

I also looked at #13 which also added password support. As I mentioned on that pull request, your implementation looks simpler to me, but if you have a chance to look at #13 and ensure Jacob hasn't caught something that you haven't thought of, that would be great!

Thanks for sending this back.

@snikch
Copy link
Contributor Author

snikch commented Apr 29, 2013

I've only checked this on IE8+, Chrome and Firefox current, so I cannot promise it works all the way back, however I definitely think it's a better solution unless there are browsers that my solution doesn't work with.

@andrewrjones
Copy link
Owner

I checked in IE6, and changing the input type from text to password doesn't seem to work.

The answer recommended on SO is to create another input box, which is what @jacobbolton does, so will try that approach.

@hello-josh
Copy link

Is IE6 relevant still? Even IE7 is on its way out now

@andrewrjones
Copy link
Owner

Thats a fair question.

The whole point of this plugin is to provide placeholder support in browsers which don't support it, which is really only IE <10. IE6 and IE7 only make up 0.9%.

Then again, if its not too difficult to continue supporting old browsers then it causes no harm. At the moment, the plugin supports IE6. Only password support does not work.

According to the SO post, changing the input type to/from password is broken in all IE's, so this approach still wouldn't work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants