Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Conversation

@jacobbolton
Copy link

Hi Andrew,

Thanks for this plug-in. It's working great providing IE support for placeholders. I have tested. The ability to add password support was a requirement for one of our projects, so I went ahead and added this support. Feel free to review the code. It basically creates a "fake" text input until a user actually gives it focus, then switches it out with the real password field. I'm open to suggestions or concerns.

Thanks again for your hard work on this!

Jacob Bolton

@andrewrjones
Copy link
Owner

Hi Jacob,

Thanks for this, and sorry for not getting time to look at it sooner.

I think your code looks good and it seems to work well.

However, @snikch also has a pull request open, and he has taken a slightly different approach. Instead of creating a fake field, he simply changes the type of the textfield from password to text, changing it back as required (see #11).

What do you think of that approach? It seems simpler to me, but I might be missing something.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants