[FIX] Fix unit test failure on local machine in BookieSocketAddressTest.#4711
Open
Jason918 wants to merge 1 commit intoapache:masterfrom
Open
[FIX] Fix unit test failure on local machine in BookieSocketAddressTest.#4711Jason918 wants to merge 1 commit intoapache:masterfrom
Jason918 wants to merge 1 commit intoapache:masterfrom
Conversation
…al system configuration - Replace direct network calls with Mockito mocks in BookieSocketAddressTest - Add mockHostnameIPSetup helper method to simulate DNS.getDefaultIP behavior - Remove dependency on actual network configuration and loopback addresses - Ensure consistent test behavior across different environments - All 4 existing tests pass with the mock implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
The unit tests in
BookieSocketAddressTestwere dependent on local system network configuration, particularly the use of loopback addresses (127.0.0.1). This caused inconsistent test behavior across different environments and could lead to test failures when loopback addresses were restricted by system configuration.Changes
mockHostnameIPSetuphelper method using Mockito.mockStatic to simulate DNS.getDefaultIP behaviortestBookieAddressIsIPAddressByDefaultto use mock instead of actual loopback addressestestBookieAddressIsHostnameto use mock with resolvable localhost addresstestAdvertisedWithNonLoopbackAddressby removing complex local network detection logicKey improvements:
Verification: