Skip to content

[FIX] Fix unit test failure on local machine in BookieSocketAddressTest. #4711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jason918 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FIX] Fix unit test failure on local machine in BookieSocketAddressTest. #4711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 33 additions & 16 deletions bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieSocketAddressTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,22 @@
import static org.assertj.core.api.Assertions.assertThatThrownBy;

import com.google.common.net.InetAddresses;
import java.net.InetAddress;
import java.net.UnknownHostException;
import org.apache.bookkeeper.conf.ServerConfiguration;
import org.apache.bookkeeper.net.BookieSocketAddress;
import org.apache.bookkeeper.net.DNS;
import org.junit.Test;
import org.mockito.MockedStatic;
import org.mockito.Mockito;

public class BookieSocketAddressTest {

private MockedStatic<DNS> mockHostnameIPSetup(String mockHostAddress) {
MockedStatic<DNS> mockedDNS = Mockito.mockStatic(DNS.class);
mockedDNS.when(() -> DNS.getDefaultIP("default")).thenReturn(mockHostAddress);
return mockedDNS;
}

private void testAdvertisedWithLoopbackAddress(String address) throws UnknownHostException {
ServerConfiguration conf = new ServerConfiguration();
conf.setAdvertisedAddress(address);
Expand All @@ -49,29 +57,38 @@ public void testAdvertisedWithLoopbackAddress() throws UnknownHostException {

@Test
public void testAdvertisedWithNonLoopbackAddress() throws UnknownHostException {
String hostAddress = InetAddress.getLocalHost().getHostAddress();
if (hostAddress == null) {
throw new UnknownHostException("Host address is null");
// Mock to return a non-loopback address
try (MockedStatic<DNS> mockedDNS = mockHostnameIPSetup("192.168.1.100")) {
ServerConfiguration conf = new ServerConfiguration();
conf.setAllowLoopback(false);
conf.setAdvertisedAddress("192.168.1.100");
BookieSocketAddress bookieAddress = getBookieAddress(conf);
assertThat(bookieAddress.getHostName()).isEqualTo("192.168.1.100");
}
ServerConfiguration conf = new ServerConfiguration();
conf.setAllowLoopback(false);
conf.setAdvertisedAddress(hostAddress);
BookieSocketAddress bookieAddress = getBookieAddress(conf);
assertThat(bookieAddress.getHostName()).isEqualTo(hostAddress);
}

@Test
public void testBookieAddressIsIPAddressByDefault() throws UnknownHostException {
ServerConfiguration conf = new ServerConfiguration();
BookieSocketAddress bookieAddress = getBookieAddress(conf);
assertThat(InetAddresses.isInetAddress(bookieAddress.getHostName())).isTrue();
// Mock to return a non-loopback address
try (MockedStatic<DNS> mockedDNS = mockHostnameIPSetup("192.168.1.100")) {
ServerConfiguration conf = new ServerConfiguration();
// Do not allow loopback addresses
conf.setAllowLoopback(false);
BookieSocketAddress bookieAddress = getBookieAddress(conf);
assertThat(InetAddresses.isInetAddress(bookieAddress.getHostName())).isTrue();
}
}

@Test
public void testBookieAddressIsHostname() throws UnknownHostException {
ServerConfiguration conf = new ServerConfiguration();
conf.setUseHostNameAsBookieID(true);
BookieSocketAddress bookieAddress = getBookieAddress(conf);
assertThat(InetAddresses.isInetAddress(bookieAddress.getHostName())).isFalse();
// Mock to return localhost address which can be resolved to a hostname
try (MockedStatic<DNS> mockedDNS = mockHostnameIPSetup("127.0.0.1")) {
ServerConfiguration conf = new ServerConfiguration();
conf.setUseHostNameAsBookieID(true);
// Allow loopback addresses since we're testing hostname resolution
conf.setAllowLoopback(true);
BookieSocketAddress bookieAddress = getBookieAddress(conf);
assertThat(InetAddresses.isInetAddress(bookieAddress.getHostName())).isFalse();
}
}
}
Loading