remove Project Template Permissions inhibition

[DaanHoogland]

Description

This PR removes the inhibition for projects to update template permissions.

Fixes: #7350

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.28%. Comparing base (7dce3d8) to head (aa4b0fd).
Report is 1 commits behind head on 4.19.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #9196       +/-   ##
============================================
- Coverage     14.95%   4.28%   -10.68%     
============================================
  Files          5382     363     -5019     
  Lines        470092   29395   -440697     
  Branches      57685    5139    -52546     
============================================
- Hits          70311    1260    -69051     
+ Misses       391993   27992   -364001     
+ Partials       7788     143     -7645     

Flag	Coverage Δ
uitests	4.28% <ø> (-0.01%)	⬇️
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yadvr]

LGTM - but worth testing, if templates owned by projects shared with accounts and other projects, can actually be listed by non-project accounts and other projects? May be also worth adding a Marvin test.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9942

[vishesh92]

clgtm

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[vishesh92]

@DaanHoogland I tested the below scenario in an env with a Simulator zone:

1. Create a normal user
2. Create a project
3. Create a template with admin account in a project
4. Share the template with the normal user

Now the normal user doesn't have access to the project.

Toggling the Projects button, I can see the template.

I couldn't deploy a VM via UI because I couldn't see the template while launching the VM.

I am not sure if this is intended or if this is another bug or an enhancement?

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10017

[DaanHoogland]

@DaanHoogland I tested the below scenario in an env with a Simulator zone:

1. Create a normal user

2. Create a project

3. Create a template with admin account in a project

4. Share the template with the normal user

...

I am not sure if this is intended or if this is another bug or an enhancement?

as discussed I think the deplpoy wizard can not handle the truth. I'll have a look. thanks @vishesh92

[DaanHoogland]

@vishesh92 , seemed trivial. I have now added the projectid=-1 parameter to the api call in the deploy wizard. Can you re-test/-check/-view?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10036

[sureshanaparti]

clgtm

[vishesh92]

@DaanHoogland Tested now. Able to launch a VM using the shared template using UI.

[slavkap]

Hi all, on my dev. environments I don't work with projects (and I'm not very familiar with this option). I don't see any available templates when using the deploy VM wizard because of the projectid=-1 in the API call. Should this be handled in the backend?

[DaanHoogland]

Hi all, on my dev. environments I don't work with projects (and I'm not very familiar with this option). I don't see any available templates when using the deploy VM wizard because of the projectid=-1 in the API call. Should this be handled in the backend?

No @slavkap I think another parameter needs to be set as well, or the the parameter needs to be optional (as in list templates)

[vishesh92]

@slavkap @DaanHoogland I have created a PR to fix this issue here: #9300