ui: fix user create featured template from volume

[shwstppr]

Description

Fixes #9241

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.29%. Comparing base (8d02e5f) to head (fa35b8c).
Report is 7 commits behind head on 4.19.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #9253       +/-   ##
============================================
- Coverage     14.95%   4.29%   -10.67%     
============================================
  Files          5378     363     -5015     
  Lines        469930   29393   -440537     
  Branches      59422    5138    -54284     
============================================
- Hits          70301    1261    -69040     
+ Misses       391842   27989   -363853     
+ Partials       7787     143     -7644     

Flag	Coverage Δ
uitests	4.29% <ø> (-0.01%)	⬇️
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9253 (QA-JID-381)

[sureshanaparti]

clgtm

[DaanHoogland]

@shwstppr , I tried in qa but see no featured field:

with change it looks good but without (qa without PR uri) it looks the same. Any extra condition I am missing maybe?

[shwstppr]

@DaanHoogland I was able to see featured selection option in UI without fix in QA server.
Go to ROOT volume of a stopped VM and create template option.

Before:

After:

[DaanHoogland]

ok @shwstppr , probably I'm creating the wrong template. I'll try again.

[DaanHoogland]

indeed I think I was at the wrong location. however the create template from volume works in the before situation and not in the PR specific code.

pressing it gives no popup. I tried with clear cache and in private window. Also I tried edge and chrome.

[shwstppr]

@DaanHoogland there was a js error earlier. I forgot to kick UI build

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9253 (QA-JID-384)

[DaanHoogland]

verified to work