fix 0.5.x release cargo publish
#1379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liurenjie1024
previously approved these changes
May 27, 2025
|
im going to test the github action on my fork first before merging |
|
The ut failure is caused by generating doc. I think we could remove those docs for now. |
kevinjqliu
commented
May 27, 2025
| @@ -21,7 +21,9 @@ | |||
| //! | |||
| //! ## Scan A Table | |||
| //! | |||
| //! ```rust, no_run | |||
| //! ```rust, ignore | |||
There was a problem hiding this comment.
@liurenjie1024 wdyt of using ignore here for now? i didnt want to remove all the docs
There was a problem hiding this comment.
Yes, it's fine to me.
11 tasks
liurenjie1024
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This PR removes
iceberg-catalog-memoryas a dev-dependency ofcrates/iceberg. The dependency is not used and causedcargo publishto fail during the 0.5.0 release (See #1325 (comment))This PR also changes
.github/workflows/release_python.ymlto depend onpublish.ymlsince we only want to publishpyiceberg-coreto pypi after the crates are successfully published.https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-a-workflow-based-on-the-conclusion-of-another-workflow
Are these changes tested?
Yes, I tested the github action changes by pushing this PR to my fork's
mainand then push a new tag, with some minor changes so that the github action can run succesfully.The tag push triggered the
Publishworkflow (https://github.com/kevinjqliu/iceberg-rust/actions/runs/15265739052) which ran successfully and triggered thePublish Python 🐍 distribution 📦 to PyPIworkflow (https://github.com/kevinjqliu/iceberg-rust/actions/runs/15265757444)