Skip to content

Conversation

mjsax
Copy link
Member

@mjsax mjsax commented Sep 19, 2025

We need to only pass in the reset strategy, as the logMessage
parameter was removed.

Reviewers: Chia-Ping Tsai chia7712@gmail.com, Lucas Brutschy
lbrutschy@confluent.io

@mjsax mjsax added the streams label Sep 19, 2025
@github-actions github-actions bot added the small Small PRs label Sep 19, 2025
@mjsax
Copy link
Member Author

mjsax commented Sep 19, 2025

This issue was introduced with 6cdb8c3 in AK 4.0.0 release.

We should cherry-pick the fix accordingly.

Copy link
Member

@lucasbru lucasbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I had the same PR locally.

Can I hijack this PR for a different change? We don't seem to log at all when we receive a InvalidOffsetException from Consumer.poll - so it's not clear where we call this function from the logs. So I would like to have a

        } catch (final InvalidOffsetException e) {
            log.info("Found no valid offset for {} partitions, resetting.", e.partitions().size());
            resetOffsets(e.partitions(), e);
        }

in StreamThread.pollRequests. Maybe you can add this here, otherwise I will push a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants