Skip to content

MINOR: fix incorrect offset reset logging #20558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 22, 2025
Merged

MINOR: fix incorrect offset reset logging #20558

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63ade62
MINOR: fix incorrect offset reset logging
mjsax Sep 19, 2025
c244ad3
update
mjsax Sep 19, 2025
5958db0
cleanup
mjsax Sep 19, 2025
b1e862f
review comment
mjsax Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1532,6 +1532,7 @@ private ConsumerRecords<byte[], byte[]> pollRequests(final Duration pollTime) {
try {
records = mainConsumer.poll(pollTime);
} catch (final InvalidOffsetException e) {
log.info("Found no valid offset for {} partitions, resetting.", e.partitions().size());
resetOffsets(e.partitions(), e);
}

Expand Down Expand Up @@ -1647,22 +1648,22 @@ private void resetOffsets(final Set<TopicPartition> partitions, final Exception
addToResetList(
partition,
seekToBeginning,
"Setting topic '{}' to consume from earliest offset",
"Setting topic '{}' to consume from 'earliest' offset",
loggedTopics
);
} else if (resetPolicy == AutoOffsetResetStrategy.LATEST) {
addToResetList(
partition,
seekToEnd,
"Setting topic '{}' to consume from latest offset",
"Setting topic '{}' to consume from 'latest' offset",
loggedTopics
);
} else if (resetPolicy.type() == AutoOffsetResetStrategy.StrategyType.BY_DURATION) {
addToResetList(
partition,
seekByDuration,
resetPolicy.duration().get(),
"Setting topic '{}' to consume from by_duration:{}",
"Setting topic '{}' to consume from 'by_duration:{}'",
resetPolicy.duration().get().toString(),
loggedTopics
);
Expand Down Expand Up @@ -1778,12 +1779,12 @@ private void resetOffsets(final Set<TopicPartition> partitions, final Exception
private void addToResetList(
final TopicPartition partition,
final Set<TopicPartition> partitions,
final String resetPolicy,
final String logMessage,
final Set<String> loggedTopics
) {
final String topic = partition.topic();
if (loggedTopics.add(topic)) {
log.info("Setting topic '{}' to consume from {} offset", topic, resetPolicy);
log.info(logMessage, topic);
}
partitions.add(partition);
}
Expand Down