Skip to content

GH-3372: Enhance ColumnSizeCommand to sort by size #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wgtmac wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GH-3372: Enhance ColumnSizeCommand to sort by size #3371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 67 additions & 5 deletions parquet-cli/src/main/java/org/apache/parquet/cli/commands/ColumnSizeCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,11 @@
import com.google.common.base.Preconditions;
import com.google.common.collect.Lists;
import java.io.IOException;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.Path;
Expand Down Expand Up @@ -56,6 +59,18 @@ public ColumnSizeCommand(Logger console) {
required = false)
List<String> columns;

@Parameter(
names = {"-s", "--sort"},
description = "Sort columns by size in descending order",
required = false)
boolean sortBySize = false;

@Parameter(
names = {"-p", "--percentage"},
description = "Print ratio as percentage instead of decimal",
required = false)
boolean printAsPercentage = false;

@Override
@SuppressWarnings("unchecked")
public int run() throws IOException {
Expand All @@ -67,6 +82,10 @@ public int run() throws IOException {

// If user defined columns, only print out size for those columns
if (columns != null && !columns.isEmpty()) {
// Collect aggregated column data
Map<String, Long> aggregatedSizes = new LinkedHashMap<>();
Map<String, Float> aggregatedRatios = new LinkedHashMap<>();

for (String inputColumn : columns) {
long size = 0;
float ratio = 0;
Expand All @@ -76,18 +95,52 @@ public int run() throws IOException {
ratio += columnRatio.get(column);
}
}
console.info(inputColumn + "->" + " Size In Bytes: " + size + " Size In Ratio: " + ratio);
aggregatedSizes.put(inputColumn, size);
aggregatedRatios.put(inputColumn, ratio);
}

// Sort if requested
List<Map.Entry<String, Long>> entries = new ArrayList<>(aggregatedSizes.entrySet());
if (sortBySize) {
entries.sort(Map.Entry.<String, Long>comparingByValue().reversed());
}

// Print results
for (Map.Entry<String, Long> entry : entries) {
String column = entry.getKey();
long size = entry.getValue();
float ratio = aggregatedRatios.get(column);
String ratioStr = formatRatio(ratio);
console.info(column + "->" + " Size In Bytes: " + size + " Size In Ratio: " + ratioStr);
}
} else {
for (String column : columnSizes.keySet()) {
console.info(column + "->" + " Size In Bytes: " + columnSizes.get(column) + " Size In Ratio: "
+ columnRatio.get(column));
// Sort if requested
List<Map.Entry<String, Long>> entries = new ArrayList<>(columnSizes.entrySet());
if (sortBySize) {
entries.sort(Map.Entry.<String, Long>comparingByValue().reversed());
}

// Print results
for (Map.Entry<String, Long> entry : entries) {
String column = entry.getKey();
long size = entry.getValue();
float ratio = columnRatio.get(column);
String ratioStr = formatRatio(ratio);
console.info(column + "->" + " Size In Bytes: " + size + " Size In Ratio: " + ratioStr);
}
}

return 0;
}

private String formatRatio(float ratio) {
if (printAsPercentage) {
return String.format(Locale.US, "%.4f%%", ratio * 100);
} else {
return String.valueOf(ratio);
}
}

@Override
public List<String> getExamples() {
return Lists.newArrayList(
Expand All @@ -96,7 +149,16 @@ public List<String> getExamples() {
"sample.parquet -c col_1",
"sample.parquet --column col_2",
"sample.parquet --columns col_1 col_2",
"sample.parquet --columns col_1 col_2.sub_col_a");
"sample.parquet --columns col_1 col_2.sub_col_a",
"# Sort columns by size in descending order",
"sample.parquet --sort",
"sample.parquet -s",
"# Print ratio as percentage",
"sample.parquet --percentage",
"sample.parquet -p",
"# Combine sorting and percentage formatting",
"sample.parquet --sort --percentage",
"sample.parquet -s -p -c col_1 col_2");
}

// Make it public to allow some automation tools to call it
Expand Down