[fix] Close TransactionBuffer when create persistent topic timeout#19384
Merged
Technoboy- merged 2 commits intoapache:masterfrom Feb 6, 2023
Merged
[fix] Close TransactionBuffer when create persistent topic timeout#19384Technoboy- merged 2 commits intoapache:masterfrom
Technoboy- merged 2 commits intoapache:masterfrom
Conversation
nicoloboschi
reviewed
Feb 1, 2023
|
|
||
| CompletableFuture<Optional<Topic>> f = brokerService.getTopic(topic, true); | ||
|
|
||
| Awaitility.waitAtMost(90, TimeUnit.SECONDS) |
Contributor
Author
There was a problem hiding this comment.
because the default value of topicLoadTimeoutSeconds is 60.
but I've fixed this, PTAL
coderzc
approved these changes
Feb 2, 2023
Technoboy-
approved these changes
Feb 6, 2023
Merged
4 tasks
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Close TransactionBuffer when create persistent topic timeout, to learn more context, please see: #19157
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: tjiuming#19